Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2528523002:
MD Settings: add unit tests for <extension-controlled-indicator> (Closed)
|
Created:
4 years ago by Dan Beam Modified:
4 years ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: add unit tests for <extension-controlled-indicator>
R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/217bd2026110cb6fcfece6dbed5053ba182f6027
Cr-Commit-Position: refs/heads/master@{#434920}
Patch Set 1 : ads #
Total comments: 2
Patch Set 2 : dpapad@ review #Patch Set 3 : minus dep #
Messages
Total messages: 29 (18 generated)
Description was changed from ========== MD Settings: add unit tests for <extension-controlled-indicator> R=dpapad@chromium.org BUG=614265 ========== to ========== MD Settings: add unit tests for <extension-controlled-indicator> R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2528523002/diff/40001/chrome/test/data/webui/... File chrome/test/data/webui/settings/extension_controlled_indicator_tests.js (right): https://codereview.chromium.org/2528523002/diff/40001/chrome/test/data/webui/... chrome/test/data/webui/settings/extension_controlled_indicator_tests.js:10: function TestExtensionControlBrowserProxy() { Can you reuse the already existing https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/test_ext... instead?
https://codereview.chromium.org/2528523002/diff/40001/chrome/test/data/webui/... File chrome/test/data/webui/settings/extension_controlled_indicator_tests.js (right): https://codereview.chromium.org/2528523002/diff/40001/chrome/test/data/webui/... chrome/test/data/webui/settings/extension_controlled_indicator_tests.js:10: function TestExtensionControlBrowserProxy() { On 2016/11/23 18:39:55, dpapad wrote: > Can you reuse the already existing > https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/test_ext... > instead? who wrote that?! Done.
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480397812575750,
"parent_rev": "18e6566c9fef47208d7729f002ec606c6810f901", "commit_rev":
"e3990bc25feaea69b764d5ea0082ed6a47508e88"}
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: add unit tests for <extension-controlled-indicator> R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: add unit tests for <extension-controlled-indicator> R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/217bd2026110cb6fcfece6dbed5053ba182f6027 Cr-Commit-Position: refs/heads/master@{#434920} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/217bd2026110cb6fcfece6dbed5053ba182f6027 Cr-Commit-Position: refs/heads/master@{#434920} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
