Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: chrome/browser/ui/views/payments/view_stack_unittest.cc

Issue 2528503002: [WebPayments] Implement state transitions in desktop WebPayments dialog. (Closed)
Patch Set: Change the ViewStack interface to take std::unique_ptr<views::View> directly. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/view_stack_unittest.cc
diff --git a/chrome/browser/ui/views/payments/view_stack_unittest.cc b/chrome/browser/ui/views/payments/view_stack_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9a58a4f95625e27876463cbcd5e289f0dd1e6e83
--- /dev/null
+++ b/chrome/browser/ui/views/payments/view_stack_unittest.cc
@@ -0,0 +1,118 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/observer_list.h"
+#include "base/run_loop.h"
+#include "chrome/browser/ui/views/payments/view_stack.h"
+#include "ui/gfx/animation/test_animation_delegate.h"
+#include "ui/views/test/views_test_base.h"
+
+class TestStackView : public views::View {
+ public:
+ class Observer {
+ public:
+ Observer() : view_deleted_(false) {}
+
+ void OnViewBeingDeleted() {
+ view_deleted_ = true;
+ }
+
+ bool view_deleted() { return view_deleted_; }
+
+ private:
+ bool view_deleted_;
+ };
+
+ TestStackView() {}
+ ~TestStackView() override {
+ for (auto& observer: observers_) {
+ observer.OnViewBeingDeleted();
+ }
+ }
+
+ void AddObserver(Observer* observer) {
+ observers_.AddObserver(observer);
+ }
+
+ private:
+ base::ObserverList<Observer> observers_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestStackView);
+};
+
+class ViewStackTest : public views::ViewsTestBase {
+ public:
+ ViewStackTest() {
+ view_stack_.reset(new ViewStack(base::MakeUnique<TestStackView>()));
+ }
+
+ std::unique_ptr<ViewStack> view_stack_;
+
+ DISALLOW_COPY_AND_ASSIGN(ViewStackTest);
+};
+
+TEST_F(ViewStackTest, TestInitialStateAddedAsChildView) {
+ EXPECT_EQ(1, view_stack_->child_count());
+}
+
+TEST_F(ViewStackTest, TestPushStateAddsViewToChildren) {
+ view_stack_->Push(base::MakeUnique<TestStackView>());
+ EXPECT_EQ(2, view_stack_->child_count());
+}
+
+TEST_F(ViewStackTest, TestPopStateRemovesChildViewAndCleansUpState) {
+ view_stack_->SetBounds(0, 0, 10, 10);
+
+ TestStackView::Observer observer;
+ std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
+ view->AddObserver(&observer);
+ views::View* view_ptr = view.get();
+
+ view_stack_->Push(std::move(view));
+ EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->slide_in_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ base::RunLoop().Run();
+ EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->Pop();
+
+ EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
+ view_stack_->slide_out_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ base::RunLoop().Run();
+ EXPECT_FALSE(view_stack_->slide_out_animator_->IsAnimating());
+
+ ASSERT_TRUE(observer.view_deleted());
+}
+
+TEST_F(ViewStackTest, TestDeletingViewCleansUpState) {
+ view_stack_->SetBounds(0, 0, 10, 10);
+
+ TestStackView::Observer observer;
+ std::unique_ptr<TestStackView> view = base::MakeUnique<TestStackView>();
+ view->AddObserver(&observer);
+ views::View* view_ptr = view.get();
+
+ view_stack_->Push(std::move(view));
+ EXPECT_TRUE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->slide_in_animator_->SetAnimationDelegate(
+ view_ptr,
+ std::unique_ptr<gfx::AnimationDelegate>(
+ new gfx::TestAnimationDelegate()));
+
+ base::RunLoop().Run();
+ EXPECT_FALSE(view_stack_->slide_in_animator_->IsAnimating());
+ view_stack_->Pop();
+
+ EXPECT_TRUE(view_stack_->slide_out_animator_->IsAnimating());
+ view_stack_.reset();
+
+ ASSERT_TRUE(observer.view_deleted());
+}

Powered by Google App Engine
This is Rietveld 408576698