Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: chrome/browser/ui/views/payments/view_stack.h

Issue 2528503002: [WebPayments] Implement state transitions in desktop WebPayments dialog. (Closed)
Patch Set: Factor out ViewStack and animations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/view_stack.h
diff --git a/chrome/browser/ui/views/payments/view_stack.h b/chrome/browser/ui/views/payments/view_stack.h
new file mode 100644
index 0000000000000000000000000000000000000000..5e67e64e2c0365b3dce381c314a6158428fcf5ed
--- /dev/null
+++ b/chrome/browser/ui/views/payments/view_stack.h
@@ -0,0 +1,61 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_
+#define CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_
+
+#include "ui/views/view.h"
+#include "ui/views/animation/bounds_animator.h"
+#include "ui/views/animation/bounds_animator_observer.h"
+
+class ViewStackState;
+
+// This view represents a stack of views that slide in over one another from
+// left to right. It manages the animation of views that are created by
+// ViewStackState instances, as well as the lifetime of those ViewStackStates.
+// To use this class, add it to a view hierarchy, subclass ViewStackState to
+// create the views that can be pushed on the stack and call PushState/PopState
+// to animate views in and out.
+class ViewStack : public views::BoundsAnimatorObserver,
+ public views::View {
+ public:
+ explicit ViewStack(std::unique_ptr<ViewStackState> initial_state);
+ ~ViewStack() override;
+
+ // Adds a state to the stack and starts animating it in from the right.
+ void PushState(std::unique_ptr<ViewStackState> state);
+
+ // Removes a state from the stack, animates it out of view, and makes sure
+ // it's properly deleted after the animation.
+ void PopState();
+
+ // views::View:
+ // The children of this view must not be able to process events when the views
sky 2016/12/12 01:54:32 do you really want to disable all events when anim
anthonyvd 2016/12/12 17:01:56 I think we want all events disabled when animating
+ // are being animated so this returns false when an animation is in progress.
+ bool CanProcessEventsWithinSubtree() const override;
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(
+ ViewStackTest, TestPopStateRemovesChildViewAndCleansUpState);
+
+ FRIEND_TEST_ALL_PREFIXES(ViewStackTest, TestDeletingViewCleansUpState);
+
+ // Returns the top state of the stack, used in tests.
+ ViewStackState* top() { return state_stack_.top().get(); }
+
+ // views::BoundsAnimatorObserver:
+ void OnBoundsAnimatorProgressed(views::BoundsAnimator* animator) override {}
+ void OnBoundsAnimatorDone(views::BoundsAnimator* animator) override;
+
+ std::stack<std::unique_ptr<ViewStackState>> state_stack_;
+
+ std::unique_ptr<views::BoundsAnimator> slide_in_animator_;
+ std::unique_ptr<views::BoundsAnimator> slide_out_animator_;
+
+ bool can_process_events_within_subtree_;
+
+ DISALLOW_COPY_AND_ASSIGN(ViewStack);
+};
+
+#endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_

Powered by Google App Engine
This is Rietveld 408576698