Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/ui/views/payments/order_summary_state.cc

Issue 2528503002: [WebPayments] Implement state transitions in desktop WebPayments dialog. (Closed)
Patch Set: Make PaymentDialogState own the view returned through GetView Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/payments/order_summary_state.h"
6
7 #include "base/observer_list.h"
8 #include "base/strings/utf_string_conversions.h"
9 #include "ui/views/controls/button/md_text_button.h"
10 #include "ui/views/controls/label.h"
11 #include "ui/views/layout/grid_layout.h"
12
13 namespace payments {
14
15 const int kBackButtonTag = 0;
sky 2016/12/08 03:58:16 constexpr, also move into anonymous namespace and
anthonyvd 2016/12/08 20:31:22 Done.
16
17 OrderSummaryState::OrderSummaryState() {}
18
19 OrderSummaryState::~OrderSummaryState() {}
20
21 views::View* OrderSummaryState::CreateView() {
22 views::View* view = new views::View();
23 view->SetSize(gfx::Size(300, 300));
sky 2016/12/08 03:58:17 Why are you setting the size? The size should come
anthonyvd 2016/12/08 20:31:22 Done.
24
25 views::GridLayout* layout = new views::GridLayout(view);
26 view->SetLayoutManager(layout);
27 views::ColumnSet* columns = layout->AddColumnSet(0);
28 columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
29 0, views::GridLayout::USE_PREF, 0, 0);
30
31 layout->StartRow(0, 0);
32 layout->AddView(new views::Label(base::ASCIIToUTF16("Order Summary")));
sky 2016/12/08 03:58:16 Shouldn't you be looking these names up from resou
anthonyvd 2016/12/08 20:31:22 Those controls are there temporarily to have somet
33
34 layout->StartRow(0, 0);
35 views::LabelButton* back_button =
36 views::MdTextButton::CreateSecondaryUiBlueButton(
37 this, base::ASCIIToUTF16("Back"));
38 back_button->set_tag(kBackButtonTag);
39 layout->AddView(back_button);
40
41 return view;
42 }
43
44 void OrderSummaryState::AddObserver(Observer* observer) {
45 observers_.AddObserver(observer);
46 }
47
48 void OrderSummaryState::RemoveObserver(Observer* observer) {
49 observers_.RemoveObserver(observer);
50 }
51
52 void OrderSummaryState::ButtonPressed(
53 views::Button* sender, const ui::Event& event) {
54 if (!interactable())
55 return;
56
57 if (sender->tag() == kBackButtonTag) {
sky 2016/12/08 03:58:17 DCHECK_EQ as there is only one button.
anthonyvd 2016/12/08 20:31:22 Done.
58 for (auto& observer : observers_) {
59 observer.OnBackClicked();
60 }
61 }
62 }
63
64 } // namespace payments
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698