Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3237)

Unified Diff: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Issue 2528483003: [Android Downloads] Long-press menu item "Download Link" should delegate job to OfflinePages backen… (Closed)
Patch Set: Added a simple test and changes per asanka's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
index a144df7c4cdae464df51155daecf41bc870484f4..ba05d370514c520be686d9e9a85c960245cb1e1e 100644
--- a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
@@ -108,6 +108,10 @@
#include "components/navigation_interception/intercept_navigation_delegate.h"
#endif
+#if BUILDFLAG(ANDROID_JAVA_UI)
+#include "chrome/browser/android/offline_pages/downloads/resource_throttle.h"
+#endif
+
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/login/signin/merge_session_resource_throttle.h"
#include "chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h"
@@ -545,6 +549,11 @@ void ChromeResourceDispatcherHostDelegate::DownloadStarting(
resource_context,
content::RESOURCE_TYPE_MAIN_FRAME,
throttles);
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ // On Android, forward text/html downloads to OfflinePages backend.
+ throttles->push_back(
Pete Williamson 2016/12/19 21:48:58 Should the throttle be pushed back *before* we cal
Dmitry Titov 2016/12/19 22:39:32 See the earlier comment by asanka on this CL. We n
+ new offline_pages::downloads::ResourceThrottle(request));
+#endif
}
}

Powered by Google App Engine
This is Rietveld 408576698