[Android Downloads] Long-press menu item "Download Link" should delegate job to OfflinePages backen…

chrome/browser/android/offline_pages/offline_page_utils.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_utils.h"
 
 #include "base/bind.h"
+#include "base/guid.h"
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 #include "chrome/browser/android/tab_android.h"
 #include "components/offline_pages/background/request_coordinator.h"
 #include "components/offline_pages/background/save_page_request.h"
 #include "components/offline_pages/client_namespace_constants.h"
 #include "components/offline_pages/client_policy_controller.h"
 #include "components/offline_pages/offline_page_feature.h"
@@ skipping 182 matching lines @@
                                               const GURL& rhs) {
   GURL::Replacements remove_params;
   remove_params.ClearRef();
 
   GURL lhs_stripped = lhs.ReplaceComponents(remove_params);
   GURL rhs_stripped = lhs.ReplaceComponents(remove_params);
 
   return lhs_stripped == rhs_stripped;
 }
 
+void OfflinePageUtils::CreateOfflinePageDownload(
+    content::BrowserContext* context,
+    const GURL& url) {
+  RequestCoordinator* request_coordinator =

[jianli, 2016/11/23 01:27:32]

RequestCoordinator instance will be null (per
https://codereview.chromium.org/2522073002/) under incognito mode since
OfflinePageModel is not created. Do we want to handle this?

[Pete Williamson, 2016/11/23 01:42:40]

Drive-by:  May I suggest returning early if the request_coordinator pointer is
null?

[Dmitry Titov, 2016/11/23 20:18:00]

Done.

+      RequestCoordinatorFactory::GetForBrowserContext(context);
+
+  ClientId client_id;

[jianli, 2016/11/23 01:27:32]

Probably better to say:
  ClientId client_id(kDownloadNamespace, base::GenerateGUID());

[Dmitry Titov, 2016/11/23 20:18:00]

Done.

+  client_id.name_space = kDownloadNamespace;
+  client_id.id = base::GenerateGUID();
+
+  request_coordinator->SavePageLater(
+      url, client_id, true,
+      RequestCoordinator::RequestAvailability::ENABLED_FOR_OFFLINER);
+
+  android::OfflinePageNotificationBridge notification_bridge;
+  notification_bridge.ShowDownloadingToast();
+}
+
 }  // namespace offline_pages