Adding SwiftShader compilation to Linux

Adding SwiftShader compilation to Linux

TBR=thakis@chromium.org
BUG=630728
Committed: https://crrev.com/265c779f246369ee005a817f201907a16c25290a
Cr-Commit-Position: refs/heads/master@{#434179}

[sugoi1, 2016-11-23 15:37:16]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:37:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 16:33:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479915436750280, "parent_rev":
"52be7496fa5c1e3971a93557da58ef34f6783a0c", "commit_rev":
"c6f50c35bc877d2cce103609eea6cdf4d0e9f4d2"}

[commit-bot: I haz the power, 2016-11-23 16:33:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 16:34:49]

Description was changed from

==========
Adding SwiftShader compilation to Linux

TBR=thakis@chromium.org
BUG=630728
==========

to

==========
Adding SwiftShader compilation to Linux

TBR=thakis@chromium.org
BUG=630728

Committed: https://crrev.com/265c779f246369ee005a817f201907a16c25290a
Cr-Commit-Position: refs/heads/master@{#434179}
==========

[commit-bot: I haz the power, 2016-11-23 16:34:50]

Patchset 1 (id:??) landed as
https://crrev.com/265c779f246369ee005a817f201907a16c25290a
Cr-Commit-Position: refs/heads/master@{#434179}

[Nico, 2016-11-23 21:31:21]

this is not an appropriate use of tbr:
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...

[sugoi1, 2016-11-23 21:41:36]

On 2016/11/23 21:31:21, Nico wrote:
> this is not an appropriate use of tbr:
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...

Noted, although I though it was ok since I was essentially re-landing this
change which you had previously L-G-T-M-ed:
https://codereview.chromium.org/2330173002/

[Nico, 2016-11-23 21:44:11]

Ah ok, I forgot about that change. All good then!

On Wed, Nov 23, 2016 at 4:41 PM, <sugoi@chromium.org> wrote:

> Reviewers: Nico
> CL: https://codereview.chromium.org/2528483002/
>
> Message:
> On 2016/11/23 21:31:21, Nico wrote:
> > this is not an appropriate use of tbr:
> >
> https://www.chromium.org/developers/owners-files#TOC-
> When-to-use-To-Be-Reviewed-TBR-
>
> Noted, although I though it was ok since I was essentially re-landing this
> change which you had previously L-G-T-M-ed:
> https://codereview.chromium.org/2330173002/
>
> Description:
> Adding SwiftShader compilation to Linux
>
> TBR=thakis@chromium.org
> BUG=630728
>
> Committed: https://crrev.com/265c779f246369ee005a817f201907a16c25290a
> Cr-Commit-Position: refs/heads/master@{#434179}
>
> Affected files (+1, -1 lines):
> M BUILD.gn
>
>
> Index: BUILD.gn
> diff --git a/BUILD.gn b/BUILD.gn
> index b453d53febcd3a32b92e0d99ff3e4dd70adc5939..
> efd8a2957d4839851420a379e9c3aec5199692c4 100644
> --- a/BUILD.gn
> +++ b/BUILD.gn
> @@ -525,7 +525,7 @@ group("both_gn_and_gyp") {
> ]
> }
>
> - if (is_win || is_mac) {
> + if (is_win || is_mac || is_linux) {
> deps += [ "//third_party/swiftshader" ]
> }
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sugoi1, 2016-11-23 22:02:26]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2526043003/ by sugoi@chromium.org.

The reason for reverting is: broke ClangToTLinuxUBSanVptr bot.