Issue 2528433007: VM: Fix potential problem with visiting stack frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2528433007: VM: Fix potential problem with visiting stack frames. (Closed)

Created:
4 years ago by Florian Schneider

Modified:
4 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix potential problem with visiting stack frames. LookupDartCode would only return a non-null coe object for regular functions, but not for stub code objects. We should also visit pointers for stub code objects. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ff483c2a78ac7ebe695635830fa267d8416575d3

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/stack_frame.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years ago (2016-11-29 17:57:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff483c2a78ac7ebe695635830fa267d8416575d3 (presubmit successful).