Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2528433006: [LayoutNG] Unit tests for MinAndMaxContentSizes::ShrinkToFit(). (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
atotic
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Unit tests for MinAndMaxContentSizes::ShrinkToFit(). Also DCHECK in the implementation that max_content isn't less than min_content. Committed: https://crrev.com/c255d0b0d14ccd32c7c88b009cbd0c94291fa3e1 Cr-Commit-Position: refs/heads/master@{#434458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mstensho (USE GERRIT)
First I actually thought that the shrink-to-fit algorithm should say: max(min_content, min(max_content, available_space)) So I ...
4 years ago (2016-11-23 21:19:49 UTC) #3
atotic
On 2016/11/23 at 21:19:49, mstensho wrote: > First I actually thought that the shrink-to-fit algorithm ...
4 years ago (2016-11-24 23:19:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528433006/1
4 years ago (2016-11-25 07:17:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 08:53:44 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-25 08:55:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c255d0b0d14ccd32c7c88b009cbd0c94291fa3e1
Cr-Commit-Position: refs/heads/master@{#434458}

Powered by Google App Engine
This is Rietveld 408576698