Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2528433003: s390: using uintptr to fix gcc error (Closed)

Created:
4 years, 1 month ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: using uintptr to fix gcc error Wsign-compare was recently added which exposed this issue. Using the correct type fixes the error. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/9d1d3878dd83e533eda96852aa920cd1e0425b26 Cr-Commit-Position: refs/heads/master@{#41196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/s390/simulator-s390.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
4 years, 1 month ago (2016-11-22 22:30:42 UTC) #1
JoranSiu
On 2016/11/22 22:30:42, JaideepBajwa (OOO) wrote: > ptal lgtm
4 years, 1 month ago (2016-11-22 22:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528433003/1
4 years, 1 month ago (2016-11-22 22:40:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 23:07:26 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 23:07:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d1d3878dd83e533eda96852aa920cd1e0425b26
Cr-Commit-Position: refs/heads/master@{#41196}

Powered by Google App Engine
This is Rietveld 408576698