Issue 252843005: Fix TextTrackList event attribute lookups when in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252843005: Fix TextTrackList event attribute lookups when in a detached state. (Closed)

Created:
6 years, 7 months ago by sof

Modified:
6 years, 7 months ago

Reviewers:
haraken, acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, ojan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix TextTrackList event attribute lookups when in a detached state. The TextTrackList object that is attached to a media element can (non Oilpan) live beyond that of its owning media element. The object is also an event target, with the events being fired by its owning media element. Consequently, the execution context is equal to that of its owner element. Adjust the TextTrackList's execution context lookup to reflect that -- if the owner element is not present, there simply is no execution context. R=haraken@chromium.org BUG=365260 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172741

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/html/track/TextTrackList.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. Following up on the crashing issue mentioned while moving the track ...

6 years, 7 months ago (2014-04-28 07:25:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/252843005/1

6 years, 7 months ago (2014-04-28 09:54:34 UTC) #4

Message was sent while issue was closed.

Change committed as 172741

Expand Messages | Collapse Messages