Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 25284005: cc: Add best_record_time to rendering stats. (Closed)

Created:
7 years, 2 months ago by ernstm
Modified:
7 years, 2 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Add best_record_time to rendering stats. - Symmetric to best_rasterize_time. - In preparation for moving rasterize_and_record benchmark to tracing based architecture. R=nduca@chromium.org BUG=280638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226345

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -32 lines) Patch
M cc/debug/rendering_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/debug/rendering_stats.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/debug/rendering_stats_instrumentation.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/picture.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/picture.cc View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture_pile.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/picture_unittest.cc View 8 chunks +6 lines, -14 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/metrics/gpu_rendering_stats.py View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/perf/metrics/smoothness.py View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ernstm
7 years, 2 months ago (2013-09-30 22:14:15 UTC) #1
nduca
lgtm
7 years, 2 months ago (2013-10-01 20:43:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/25284005/1
7 years, 2 months ago (2013-10-01 20:53:36 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/perf/metrics/smoothness.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-01 20:53:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/25284005/7001
7 years, 2 months ago (2013-10-01 21:12:49 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 23:39:38 UTC) #6
Message was sent while issue was closed.
Change committed as 226345

Powered by Google App Engine
This is Rietveld 408576698