Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2528373002: Clarify AndroidStatusFetcher documentation (Closed)

Created:
4 years ago by ljusten (tachyonic)
Modified:
4 years ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify AndroidStatusFetcher documentation Explained in what cases AndroidStatusFetcher returns false. BUG=None Committed: https://crrev.com/bdb82e7f8633ef16626bca1eabb74e5b26fc4018 Cr-Commit-Position: refs/heads/master@{#434632}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Clarify AndroidStatusFetcher documentation #

Patch Set 3 : Clarify AndroidStatusFetcher documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/chromeos/policy/device_status_collector.h View 1 2 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ljusten (tachyonic)
As discussed on Hangouts.
4 years ago (2016-11-28 10:31:33 UTC) #2
Andrew T Wilson (Slow)
LGTM with one more fixup to do https://codereview.chromium.org/2528373002/diff/1/chrome/browser/chromeos/policy/device_status_collector.h File chrome/browser/chromeos/policy/device_status_collector.h (right): https://codereview.chromium.org/2528373002/diff/1/chrome/browser/chromeos/policy/device_status_collector.h#newcode87 chrome/browser/chromeos/policy/device_status_collector.h:87: // Blocking ...
4 years ago (2016-11-28 10:37:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528373002/40001
4 years ago (2016-11-28 10:48:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 11:14:15 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-28 11:16:51 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bdb82e7f8633ef16626bca1eabb74e5b26fc4018
Cr-Commit-Position: refs/heads/master@{#434632}

Powered by Google App Engine
This is Rietveld 408576698