Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2528333002: ServiceWorker: Change DCHECK to CHECK for debugging process allocation (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Change DCHECK to CHECK for debugging process allocation This patch is to confirm if the process allocation works well. BUG=668633 Committed: https://crrev.com/21c5638d913d1147a0a3e6a69c69ebe9bfa993bb Cr-Commit-Position: refs/heads/master@{#434628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
shimazu
ptal
4 years ago (2016-11-28 08:56:02 UTC) #3
falken
lgtm for debug
4 years ago (2016-11-28 09:10:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528333002/1
4 years ago (2016-11-28 09:11:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 10:28:01 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/21c5638d913d1147a0a3e6a69c69ebe9bfa993bb Cr-Commit-Position: refs/heads/master@{#434628}
4 years ago (2016-11-28 10:29:31 UTC) #11
shimazu
4 years ago (2016-12-08 05:06:02 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2563583002/ by shimazu@chromium.org.

The reason for reverting is: There was no crash came from this CHECK..

Powered by Google App Engine
This is Rietveld 408576698