Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 252833005: Reland "GestureRecognizerTest tests both Aura and Unified Gesture Detectors." (Closed)

Created:
6 years, 7 months ago by tdresser
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Reland "GestureRecognizerTest tests both Aura and Unified Gesture Detectors." Reland "GestureRecognizerTest tests both Aura and Unified Gesture Detectors." This is in preparation of landing the unified GR (see https://codereview.chromium.org/251543003/). There are some cases where behavior differs in minor ways. This is sometimes dealt with by increasing the test's margin of error (for instance, slop handling is slightly different, so we now exceed the slop more thoroughly). This is sometimes dealt with by ignoring the test if the test is run with the unified GR. BUG=332418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266652

Patch Set 1 #

Patch Set 2 : Fix failing test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -113 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 81 chunks +269 lines, -112 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tdresser
sadrul@, relanding after https://codereview.chromium.org/258633005/ was reverted due to a compile error under gcc. PTAL.
6 years, 7 months ago (2014-04-28 13:36:17 UTC) #1
sadrul
lgtm
6 years, 7 months ago (2014-04-28 14:11:38 UTC) #2
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 7 months ago (2014-04-28 14:16:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/252833005/20001
6 years, 7 months ago (2014-04-28 14:19:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:04:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 15:04:37 UTC) #6
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 7 months ago (2014-04-28 15:26:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/252833005/20001
6 years, 7 months ago (2014-04-28 15:26:42 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:55:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 16:56:00 UTC) #10
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 7 months ago (2014-04-28 18:08:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/252833005/20001
6 years, 7 months ago (2014-04-28 18:10:09 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 20:52:27 UTC) #13
Message was sent while issue was closed.
Change committed as 266652

Powered by Google App Engine
This is Rietveld 408576698