Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm b/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
index 10a9b92e35568b124494ff681ee06e5747bb5512..d77d3d6247cac10fb336e8b8a8638ca5895fce3c 100644
--- a/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
+++ b/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
@@ -342,7 +342,8 @@ enum CellType {
[self dismissRecentTabsModal];
if (openTabs->GetForeignTab(distantTab->session_tag, distantTab->tab_id,
&toLoad)) {
- base::RecordAction(base::UserMetricsAction("MobileNTPForeignSession"));
+ base::RecordAction(base::UserMetricsAction(
+ "MobileRecentTabManagerTabFromOtherDeviceOpened"));
new_tab_page_uma::RecordAction(
_browserState, new_tab_page_uma::ACTION_OPENED_FOREIGN_SESSION);
[_loader loadSessionTab:toLoad];
@@ -361,7 +362,8 @@ enum CellType {
TabRestoreServiceDelegateImplIOSFactory::GetForBrowserState(
_browserState);
[self dismissRecentTabsModal];
- base::RecordAction(base::UserMetricsAction("MobileNTPRecentlyClosed"));
+ base::RecordAction(
+ base::UserMetricsAction("MobileRecentTabManagerRecentTabOpened"));
new_tab_page_uma::RecordAction(
_browserState, new_tab_page_uma::ACTION_OPENED_RECENTLY_CLOSED_ENTRY);
_tabRestoreService->RestoreEntryById(delegate, entry->id,
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698