Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Changed order of UMA calls in ChromeTabbedActivity.java Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 4701a6b175ccf433e3dcb8a43514f6115a880012..08f91097f70a7508c1737eaf3ec6b0f4f131395f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -79,6 +79,7 @@ import org.chromium.chrome.browser.metrics.StartupMetrics;
import org.chromium.chrome.browser.metrics.UmaUtils;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.ntp.NativePageAssassin;
+import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.omaha.OmahaClient;
import org.chromium.chrome.browser.omnibox.AutocompleteController;
@@ -1125,6 +1126,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
@Override
public boolean onMenuOrKeyboardAction(final int id, boolean fromMenu) {
final Tab currentTab = getActivityTab();
+ boolean currentTabIsNtp = currentTab != null && NewTabPage.isNTPUrl(currentTab.getUrl());
if (id == R.id.move_to_other_window_menu_id) {
if (currentTab != null) moveTabToOtherWindow(currentTab);
} else if (id == R.id.new_tab_menu_id) {
@@ -1153,6 +1155,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
BookmarkUtils.showBookmarkManager(ChromeTabbedActivity.this);
}
});
+ if (currentTabIsNtp) {
+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARKS_MANAGER);
+ }
RecordUserAction.record("MobileMenuAllBookmarks");
}
} else if (id == R.id.recent_tabs_menu_id) {
@@ -1160,6 +1165,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
currentTab.loadUrl(new LoadUrlParams(
UrlConstants.RECENT_TABS_URL,
PageTransition.AUTO_BOOKMARK));
+ if (currentTabIsNtp) {
+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_RECENT_TABS_MANAGER);
+ }
RecordUserAction.record("MobileMenuOpenTabs");
}
} else if (id == R.id.close_all_tabs_menu_id) {
@@ -1189,6 +1197,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
} else if (id == R.id.downloads_menu_id) {
DownloadUtils.showDownloadManager(this, currentTab);
+ if (currentTabIsNtp) {
+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_DOWNLOADS_MANAGER);
+ }
RecordUserAction.record("MobileMenuDownloadManager");
} else if (id == R.id.open_recently_closed_tab) {
TabModel currentModel = mTabModelSelectorImpl.getCurrentModel();

Powered by Google App Engine
This is Rietveld 408576698