Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 2528303003: [NTP] Fixed usage of NewTabPage.ActionAndroid histogram (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
index 9ab1e77fc61714e52a45646f83f26b5de46aa9da..7ac51cbd06ff355a73610051386f234a1cd0ac2c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
@@ -21,7 +21,6 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
-import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
@@ -230,7 +229,7 @@ public class BookmarkUtils {
String url = model.getBookmarkById(bookmarkId).getUrl();
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);
+ RecordUserAction.record("MobileBookmarkOpen");
dgn 2016/12/22 12:31:22 FYI: this is called only from the bookmark manager
finkm 2016/12/22 13:53:42 Yep. This is intentional.
Mark P 2016/12/22 18:42:57 Are there bookmarks on the (mobile) NTP? If no, t
finkm 2017/01/03 10:43:52 Done.
RecordHistogram.recordEnumeratedHistogram(
"Stars.LaunchLocation", launchLocation, BookmarkLaunchLocation.COUNT);

Powered by Google App Engine
This is Rietveld 408576698