Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2528293002: [fullcodegen] Remove deprecated support for new.target and rest parameters. (Closed)
Patch Set: Now with green bots AKA fix copy-and-paste. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 } 258 }
259 } 259 }
260 } 260 }
261 261
262 // Register holding this function and new target are both trashed in case we 262 // Register holding this function and new target are both trashed in case we
263 // bailout here. But since that can happen only when new target is not used 263 // bailout here. But since that can happen only when new target is not used
264 // and we allocate a context, the value of |function_in_register| is correct. 264 // and we allocate a context, the value of |function_in_register| is correct.
265 PrepareForBailoutForId(BailoutId::FunctionContext(), 265 PrepareForBailoutForId(BailoutId::FunctionContext(),
266 BailoutState::NO_REGISTERS); 266 BailoutState::NO_REGISTERS);
267 267
268 // Possibly set up a local binding to the this function which is used in 268 // We don't support new.target and rest parameters here.
269 // derived constructors with super calls. 269 DCHECK_NULL(info->scope()->new_target_var());
270 Variable* this_function_var = info->scope()->this_function_var(); 270 DCHECK_NULL(info->scope()->rest_parameter());
271 if (this_function_var != nullptr) { 271 DCHECK_NULL(info->scope()->this_function_var());
272 Comment cmnt(masm_, "[ This function");
273 if (!function_in_register_r3) {
274 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
275 // The write barrier clobbers register again, keep it marked as such.
276 }
277 SetVar(this_function_var, r3, r2, r4);
278 }
279
280 // Possibly set up a local binding to the new target value.
281 Variable* new_target_var = info->scope()->new_target_var();
282 if (new_target_var != nullptr) {
283 Comment cmnt(masm_, "[ new.target");
284 SetVar(new_target_var, r5, r2, r4);
285 }
286
287 // Possibly allocate RestParameters
288 Variable* rest_param = info->scope()->rest_parameter();
289 if (rest_param != nullptr) {
290 Comment cmnt(masm_, "[ Allocate rest parameter array");
291
292 if (!function_in_register_r3) {
293 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
294 }
295 FastNewRestParameterStub stub(isolate());
296 __ CallStub(&stub);
297
298 function_in_register_r3 = false;
299 SetVar(rest_param, r2, r3, r4);
300 }
301 272
302 Variable* arguments = info->scope()->arguments(); 273 Variable* arguments = info->scope()->arguments();
303 if (arguments != NULL) { 274 if (arguments != NULL) {
304 // Function uses arguments object. 275 // Function uses arguments object.
305 Comment cmnt(masm_, "[ Allocate arguments object"); 276 Comment cmnt(masm_, "[ Allocate arguments object");
306 if (!function_in_register_r3) { 277 if (!function_in_register_r3) {
307 // Load this again, if it's used by the local context below. 278 // Load this again, if it's used by the local context below.
308 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 279 __ LoadP(r3, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
309 } 280 }
310 if (is_strict(language_mode()) || !has_simple_parameters()) { 281 if (is_strict(language_mode()) || !has_simple_parameters()) {
(...skipping 2834 matching lines...) Expand 10 before | Expand all | Expand 10 after
3145 DCHECK(kOSRBranchInstruction == br_instr); 3116 DCHECK(kOSRBranchInstruction == br_instr);
3146 3117
3147 DCHECK(interrupt_address == 3118 DCHECK(interrupt_address ==
3148 isolate->builtins()->OnStackReplacement()->entry()); 3119 isolate->builtins()->OnStackReplacement()->entry());
3149 return ON_STACK_REPLACEMENT; 3120 return ON_STACK_REPLACEMENT;
3150 } 3121 }
3151 3122
3152 } // namespace internal 3123 } // namespace internal
3153 } // namespace v8 3124 } // namespace v8
3154 #endif // V8_TARGET_ARCH_S390 3125 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698