Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2528293002: [fullcodegen] Remove deprecated support for new.target and rest parameters. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove deprecated support for new.target and rest parameters. This code is no longer used by full-codegen since all functions which use new.target, rest parameters or the internal this function binding now grow through Ignition first, and never tier up to fullcodegen. BUG=v8:5657 R=rmcilroy@chromium.org Committed: https://crrev.com/65fd9c430653df83dd617487b25477e44a3b8a40 Cr-Commit-Position: refs/heads/master@{#41298}

Patch Set 1 #

Patch Set 2 : Now with green bots AKA fix copy-and-paste. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -362 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 3 chunks +4 lines, -67 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -30 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +4 lines, -33 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +4 lines, -31 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +4 lines, -31 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Benedikt Meurer
4 years ago (2016-11-28 05:23:14 UTC) #1
Benedikt Meurer
Hey Ross, Here's another one. Please take a look. Thanks, Benedikt
4 years ago (2016-11-28 05:24:12 UTC) #4
rmcilroy
Awesome, LGTM, thanks!
4 years ago (2016-11-28 08:53:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528293002/20001
4 years ago (2016-11-28 08:57:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 08:59:23 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-28 09:00:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65fd9c430653df83dd617487b25477e44a3b8a40
Cr-Commit-Position: refs/heads/master@{#41298}

Powered by Google App Engine
This is Rietveld 408576698