Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2528283002: Move text-transform to be generated in ComputedStyleBase (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move text-transform to be generated in ComputedStyleBase Move the inherited property text-transform and its enum, ETextTransform, to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/2146072b9a357b2a16d8a947a1754f7b104d5a5e Cr-Commit-Position: refs/heads/master@{#435193}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 4 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
sashab
4 years ago (2016-11-28 03:24:47 UTC) #2
sashab
Hey jon -- unfortunately this CL isn't super easy to read, all the generated code ...
4 years ago (2016-11-28 03:28:36 UTC) #5
napper
https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (left): https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h#oldcode358 third_party/WebKit/Source/core/style/ComputedStyleConstants.h:358: enum class ETextTransform : unsigned { Capitalize, Uppercase, Lowercase, ...
4 years ago (2016-11-28 04:24:46 UTC) #6
napper
lgtm
4 years ago (2016-11-28 04:27:36 UTC) #7
napper
lgtm
4 years ago (2016-11-28 04:27:40 UTC) #8
sashab
alancutter@ please review :) https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (left): https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h#oldcode358 third_party/WebKit/Source/core/style/ComputedStyleConstants.h:358: enum class ETextTransform : unsigned ...
4 years ago (2016-11-30 00:41:38 UTC) #12
alancutter (OOO until 2018)
https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (left): https://codereview.chromium.org/2528283002/diff/1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h#oldcode358 third_party/WebKit/Source/core/style/ComputedStyleConstants.h:358: enum class ETextTransform : unsigned { Capitalize, Uppercase, Lowercase, ...
4 years ago (2016-11-30 03:42:40 UTC) #13
alancutter (OOO until 2018)
lgtm. initial value comment is a separate issue to this patch.
4 years ago (2016-11-30 03:43:00 UTC) #14
sashab
I agree 100%. Will add initial= to all currently generated proeprties in a follow-up patch.
4 years ago (2016-11-30 05:29:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528283002/20001
4 years ago (2016-11-30 06:59:34 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 09:10:55 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-30 09:13:02 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2146072b9a357b2a16d8a947a1754f7b104d5a5e
Cr-Commit-Position: refs/heads/master@{#435193}

Powered by Google App Engine
This is Rietveld 408576698