Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2528263003: MD Settings: Fix Change Picture Camera icons. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix Change Picture Camera icons. Previously, the icon fill color was gray. This change restores it to white, as the specs indicate. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f002184e95a118c8f8c409ff2adf7130bfb1a7ac Cr-Commit-Position: refs/heads/master@{#434841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/settings/people_page/camera.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
tommycli
dshuyler: PTAL See http://imgur.com/a/KSaaC First screenshot is the "after". Second screenshot is the "before".
4 years ago (2016-11-29 00:11:09 UTC) #3
dschuyler
lgtm
4 years ago (2016-11-29 00:33:21 UTC) #4
tommycli
On 2016/11/29 00:33:21, dschuyler wrote: > lgtm thank you sir!
4 years ago (2016-11-29 00:38:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528263003/1
4 years ago (2016-11-29 00:40:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:47:02 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 02:53:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f002184e95a118c8f8c409ff2adf7130bfb1a7ac
Cr-Commit-Position: refs/heads/master@{#434841}

Powered by Google App Engine
This is Rietveld 408576698