third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2528253003: [table] Stretching tables when needed due to self-alignment properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2528253003: [table] Stretching tables when needed due to self-alignment properties (Closed)

Patch Set: Removed another incorrect assert. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index eda48c9efd564a5af8f583f2a8dbc59ba04660f5..0cd8bc3b78d945de045ed625f4d636905f4e6cbd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -1383,8 +1383,7 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

virtual ItemPosition selfAlignmentNormalBehavior(

const LayoutBox* child = nullptr) const {

- DCHECK(!child);

- return ItemPositionStretch;

+ return ItemPositionStart;

}

// Returns false if it could not cheaply compute the extent (e.g. fixed