Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4580)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest.cc

Issue 2528253002: Revert of WebRtcBrowserTest: Include all stats in getStats. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/webrtc_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest.cc b/chrome/browser/media/webrtc/webrtc_browsertest.cc
index 0b379e315643100f65489923b2bdc027f31c40c4..44b550582f25d2a259d9df0b7dfb10dd54f653fb 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest.cc
@@ -219,8 +219,6 @@
StartServerAndOpenTabs();
SetupPeerconnectionWithLocalStream(left_tab_);
SetupPeerconnectionWithLocalStream(right_tab_);
- CreateDataChannel(left_tab_, "data");
- CreateDataChannel(right_tab_, "data");
NegotiateCall(left_tab_, right_tab_);
std::set<std::string> missing_expected_stats;
@@ -230,9 +228,9 @@
for (const std::string& type : VerifyStatsGeneratedPromise(left_tab_)) {
missing_expected_stats.erase(type);
}
- for (const std::string& type : missing_expected_stats) {
- EXPECT_TRUE(false) << "Expected stats dictionary is missing: " << type;
- }
+ // TODO(hbos): When all stats are ready and returned by "getStats":
+ // EXPECT_TRUE(missing_expected_stats.empty());
+ // crbug.com/627816
DetectVideoAndHangUp();
}
« no previous file with comments | « no previous file | chrome/browser/media/webrtc/webrtc_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698