Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2528253002: Revert of WebRtcBrowserTest: Include all stats in getStats. (Closed)

Created:
4 years ago by Sam McNally
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, hta - Chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebRtcBrowserTest: Include all stats in getStats. (patchset #1 id:1 of https://codereview.chromium.org/2527273003/ ) Reason for revert: Failing on desktop platforms: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F49343%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests_on_Ubuntu-12.04%2F0%2Flogs%2FWebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise%2F0 Original issue's description: > WebRtcBrowserTest: Include all stats in getStats. > > The only stats dictionary that was missing was 'data-channel'. For it to > be included data channels had to be created. Added CreateDataChannel to > webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to > EXPECT that no expected stats are missing. > > BUG=chromium:627816 > > Committed: https://crrev.com/39ce516e1f6da7816c8794b4fab334230a9c84ce > Cr-Commit-Position: refs/heads/master@{#434502} TBR=phoglund@chromium.org,hbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:627816 Committed: https://crrev.com/fcad418e5a3feb8cdb031ab58081f80ce0de63b4 Cr-Commit-Position: refs/heads/master@{#434587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M chrome/browser/media/webrtc/webrtc_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/webrtc/peerconnection.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Sam McNally
Created Revert of WebRtcBrowserTest: Include all stats in getStats.
4 years ago (2016-11-27 23:06:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528253002/1
4 years ago (2016-11-27 23:06:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-27 23:53:44 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-27 23:56:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcad418e5a3feb8cdb031ab58081f80ce0de63b4
Cr-Commit-Position: refs/heads/master@{#434587}

Powered by Google App Engine
This is Rietveld 408576698