media/base/video_util.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_util.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/video_util.cc

diff --git a/media/base/video_util.cc b/media/base/video_util.cc

index f7fd47ae84b357ee20be86b401cec3fe7d8396a1..d77b0084355c37a32c3e77a24b082c4c34e1aa02 100644

--- a/media/base/video_util.cc

+++ b/media/base/video_util.cc

@@ -270,7 +270,7 @@ static int RoundedDivision(int64_t a, int b) {

base::CheckedNumeric<uint64_t> result(a);

result += b / 2;

result /= b;

- return base::checked_cast<int>(result.ValueOrDie());

+ return base::ValueOrDieForType<int>(result);

}

// Common logic for the letterboxing and scale-within/scale-encompassing