components/webcrypto/algorithms/aes_ctr.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/aes_ctr.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: fixes Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/webcrypto/algorithms/aes_ctr.cc

diff --git a/components/webcrypto/algorithms/aes_ctr.cc b/components/webcrypto/algorithms/aes_ctr.cc

index dd7f012f254c98dd17dd3bba6879163ccd08caa4..3525c5ff37d8771ef4f64a79136edc1d2ce9a1c1 100644

--- a/components/webcrypto/algorithms/aes_ctr.cc

+++ b/components/webcrypto/algorithms/aes_ctr.cc

@@ -166,7 +166,7 @@ Status AesCtrEncryptDecrypt(const blink::WebCryptoAlgorithm& algorithm,

return Status::ErrorUnexpected();

const CryptoData counter_block(params->counter());

- buffer->resize(output_max_len.ValueOrDie());

+ buffer->resize(base::ValueOrDieForType<size_t>(output_max_len));

// The total number of possible counter values is pow(2, counter_length_bits)

bssl::UniquePtr<BIGNUM> num_counter_values(BN_new());