gpu/command_buffer/client/gles2_implementation.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile cleanup and fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/client/gles2_implementation.cc

diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc

index 3424bc2a5310224463bbed535e1e84eed8e336d0..a624aa9356fd48a44e7ab753f2e5a625310ebcaf 100644

--- a/gpu/command_buffer/client/gles2_implementation.cc

+++ b/gpu/command_buffer/client/gles2_implementation.cc

@@ -6353,7 +6353,8 @@ bool GLES2Implementation::PackStringsToBucket(GLsizei count,

header[ii + 1] = len;

}

// Pack data into a bucket on the service.

- helper_->SetBucketSize(kResultBucketId, total_size.ValueOrDefault(0));

+ helper_->SetBucketSize(kResultBucketId,

+ total_size.template ValueOrDefault<uint32_t>(0));

size_t offset = 0;

for (GLsizei ii = 0; ii <= count; ++ii) {

const char* src =