base/strings/string_number_conversions.cc - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.cc

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile cleanup and fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_number_conversions.cc

diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc

index 755811ded7e32beea4221ca128fee3dc0fb2d8a9..cc4206a5d50b5f0d0f16b9002163852ce2cb5675 100644

--- a/base/strings/string_number_conversions.cc

+++ b/base/strings/string_number_conversions.cc

@@ -35,7 +35,8 @@ struct IntToStringT {

// The ValueOrDie call below can never fail, because UnsignedAbs is valid

// for all valid inputs.

- auto res = CheckedNumeric<INT>(value).UnsignedAbs().ValueOrDie();

+ typename decltype(CheckedNumeric<INT>(value).UnsignedAbs())::type res =

+ CheckedNumeric<INT>(value).UnsignedAbs().ValueOrDie();

CHR* end = outbuf + kOutputBufSize;

CHR* i = end;