third_party/crashpad/README.chromium - Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/crashpad/README.chromium

Issue 2528243002: Fix silent truncations when extracting values from CheckedNumeric (Closed)

Patch Set: compile fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 Name: Crashpad	1 Name: Crashpad

2 Short Name: crashpad	2 Short Name: crashpad

3 URL: https://crashpad.chromium.org/	3 URL: https://crashpad.chromium.org/

4 Version: unknown	4 Version: unknown

5 Revision: b47bf6c250c6b825dee1c5fbad9152c2c962e828	5 Revision: b47bf6c250c6b825dee1c5fbad9152c2c962e828

6 License: Apache 2.0	6 License: Apache 2.0

7 License File: crashpad/LICENSE	7 License File: crashpad/LICENSE

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Description:	10 Description:

(...skipping 18 matching lines...) Expand all Loading...
29 To carry changes made in Chromium to Crashpad, run:	29 To carry changes made in Chromium to Crashpad, run:

30 $ cd "${THIS_DIR}"	30 $ cd "${THIS_DIR}"

31 $ mkdir /tmp/patchdir	31 $ mkdir /tmp/patchdir

32 $ git format-patch -1 --binary --output-directory=/tmp/patchdir/cur "${HASH}" \	32 $ git format-patch -1 --binary --output-directory=/tmp/patchdir/cur "${HASH}" \

33 --add-header="Message-Id: Merged from chromium ${HASH}" -- crashpad/	33 --add-header="Message-Id: Merged from chromium ${HASH}" -- crashpad/

34 $ cd "${CRASHPAD_DIR}"	34 $ cd "${CRASHPAD_DIR}"

35 $ git am --3way --message-id -p4 /tmp/patchdir	35 $ git am --3way --message-id -p4 /tmp/patchdir

36	36

37 Local Modifications:	37 Local Modifications:

38 - Have crashpad call ASan's crash handler if present	38 - Have crashpad call ASan's crash handler if present

	39 - Modified util/file/string_file.cc for compat with base/numerics here:

	40 https://codereview.chromium.org/2528243002/

OLD	NEW

« no previous file with comments | « media/base/video_util.cc ('k') | third_party/crashpad/crashpad/util/file/string_file.cc » ('j') | no next file with comments »