Fix the bug which is login dialog won't close after the second sign-in to chrome with different acc…

Fix the bug which is login dialog won't close after the second sign-in to chrome with different account on the same profile.

This is the follow up of CLs:
1) https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
and
2) https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca04710152de495ba50ea

The javascript message that close sign in dialog will be sent regardless before. However, after the refactor in the second CL above, it's only sent once the profile_path is not empty. It didn't cause any issue because the JS message will be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign in is enabled after the first CL landed which is used to solve crbug.com/667227. It means that if the profile_path is empty (second sign in with different account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that the javascript message will be sent no matter the profile_path is empty or not.

BUG=668619
Committed: https://crrev.com/0233a4c8e8eaa98fd46de68f975286b438751211
Cr-Commit-Position: refs/heads/master@{#434668}

[zmin, 2016-11-25 18:29:10]

The CQ bit was checked by zmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 18:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zmin, 2016-11-25 18:48:05]

Description was changed from

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

BUG=668619
==========

to

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

This is the follow up of CLs:
1)
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459...
and 
2)
https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca0471015...

The javascript message that close sign in dialog will be sent regardless before.
However, after the refactor in the second CL above, it's only sent once the
profile_path is not empty. It didn't cause any issue because the JS message will
be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign
in is enabled after the first CL landed which is used to solve crbug.com/667227.
It means that if the profile_path is empty (second sign in with different
account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that
the javascript message will be sent no matter the profile_path is empty or not.


BUG=668619
==========

[zmin, 2016-11-25 18:48:39]

zmin@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[zmin, 2016-11-25 18:48:39]

Hi Anthony,

Can you review this CL please?

Owen

[commit-bot: I haz the power, 2016-11-25 19:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 19:25:03]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2016-11-28 12:36:14]

lgtm % quick clarification

https://codereview.chromium.org/2528183002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/2528183002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:123: if
(!profile_path.empty()) {
This should only be the case when sign in happens from the User Manager,
correct?

[zmin, 2016-11-28 16:07:20]

On 2016/11/28 12:36:14, anthonyvd wrote:
> lgtm % quick clarification
> 
>
https://codereview.chromium.org/2528183002/diff/1/chrome/browser/ui/webui/sig...
> File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):
> 
>
https://codereview.chromium.org/2528183002/diff/1/chrome/browser/ui/webui/sig...
> chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:123: if
> (!profile_path.empty()) {
> This should only be the case when sign in happens from the User Manager,
> correct?

Yes, I think so. The profile_path will only be set if the profile of webui is
System Profile.

[zmin, 2016-11-28 16:07:25]

The CQ bit was checked by zmin@chromium.org

[commit-bot: I haz the power, 2016-11-28 16:07:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 16:48:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480349245310650, "parent_rev":
"1dd6a8600bdff18297933f6cc99a8c84d54fcf99", "commit_rev":
"b08745c1cde0a13ca535a69c33b77968c1e2d987"}

[commit-bot: I haz the power, 2016-11-28 16:48:37]

Description was changed from

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

This is the follow up of CLs:
1)
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459...
and 
2)
https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca0471015...

The javascript message that close sign in dialog will be sent regardless before.
However, after the refactor in the second CL above, it's only sent once the
profile_path is not empty. It didn't cause any issue because the JS message will
be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign
in is enabled after the first CL landed which is used to solve crbug.com/667227.
It means that if the profile_path is empty (second sign in with different
account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that
the javascript message will be sent no matter the profile_path is empty or not.


BUG=668619
==========

to

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

This is the follow up of CLs:
1)
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459...
and 
2)
https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca0471015...

The javascript message that close sign in dialog will be sent regardless before.
However, after the refactor in the second CL above, it's only sent once the
profile_path is not empty. It didn't cause any issue because the JS message will
be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign
in is enabled after the first CL landed which is used to solve crbug.com/667227.
It means that if the profile_path is empty (second sign in with different
account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that
the javascript message will be sent no matter the profile_path is empty or not.


BUG=668619
==========

[commit-bot: I haz the power, 2016-11-28 16:48:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-28 16:52:04]

Description was changed from

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

This is the follow up of CLs:
1)
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459...
and 
2)
https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca0471015...

The javascript message that close sign in dialog will be sent regardless before.
However, after the refactor in the second CL above, it's only sent once the
profile_path is not empty. It didn't cause any issue because the JS message will
be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign
in is enabled after the first CL landed which is used to solve crbug.com/667227.
It means that if the profile_path is empty (second sign in with different
account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that
the javascript message will be sent no matter the profile_path is empty or not.


BUG=668619
==========

to

==========
Fix the bug which is login dialog won't close after the second sign-in to chrome
with different account on the same profile.

This is the follow up of CLs:
1)
https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459...
and
2)
https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca0471015...

The javascript message that close sign in dialog will be sent regardless before.
However, after the refactor in the second CL above, it's only sent once the
profile_path is not empty. It didn't cause any issue because the JS message will
be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign
in is enabled after the first CL landed which is used to solve crbug.com/667227.
It means that if the profile_path is empty (second sign in with different
account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that
the javascript message will be sent no matter the profile_path is empty or not.

BUG=668619

Committed: https://crrev.com/0233a4c8e8eaa98fd46de68f975286b438751211
Cr-Commit-Position: refs/heads/master@{#434668}
==========

[commit-bot: I haz the power, 2016-11-28 16:52:04]

Patchset 1 (id:??) landed as
https://crrev.com/0233a4c8e8eaa98fd46de68f975286b438751211
Cr-Commit-Position: refs/heads/master@{#434668}