Rewire the local sync switches through the pref store.

Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual

Committed: https://crrev.com/0c13de516027b0ac22acc891b40fea8b7149240b
Cr-Commit-Position: refs/heads/master@{#436032}

[pastarmovj, 2016-11-28 15:58:01]

pastarmovj@chromium.org changed reviewers:
+ zea@chromium.org

[pastarmovj, 2016-11-28 15:58:01]

Hi Nicolas,

This is a rather trivial CL that rewires the switches through the pref store in
preparation for hooking them up to the policies. 

Best,
Julian

[pastarmovj, 2016-11-28 15:58:18]

Description was changed from

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=TBD
==========

to

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual
==========

[Nicolas Zea, 2016-11-29 18:32:16]

lgtm

https://codereview.chromium.org/2528163002/diff/1/components/sync/base/sync_p...
File components/sync/base/sync_prefs.h (right):

https://codereview.chromium.org/2528163002/diff/1/components/sync/base/sync_p...
components/sync/base/sync_prefs.h:183: bool IsLocalSyncEnabled() const;
nit: Add comment about what these methods relate to (local loopback server)

[pastarmovj, 2016-12-01 10:15:10]

Thanks!

https://codereview.chromium.org/2528163002/diff/1/components/sync/base/sync_p...
File components/sync/base/sync_prefs.h (right):

https://codereview.chromium.org/2528163002/diff/1/components/sync/base/sync_p...
components/sync/base/sync_prefs.h:183: bool IsLocalSyncEnabled() const;
On 2016/11/29 18:32:15, Nicolas Zea wrote:
> nit: Add comment about what these methods relate to (local loopback server)

Done.

[pastarmovj, 2016-12-01 10:27:58]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2016-12-01 10:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2528163002/#ps20001
(title: "Comment new SyncPrefs methods.")

[commit-bot: I haz the power, 2016-12-01 10:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 10:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 10:33:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pastarmovj, 2016-12-01 10:35:29]

pastarmovj@chromium.org changed reviewers:
+ bauerb@chromium.org

[pastarmovj, 2016-12-01 10:35:30]

Bernhard, please review changes in chrome/browser/prefs.

Thanks!

[Bernhard Bauer, 2016-12-01 23:56:34]

lgtm

[pastarmovj, 2016-12-02 20:19:18]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:19:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:28:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480709958247260,
"parent_rev": "6ba6f22a9bc5efab474a1d3eddfe45dc4d33f475", "commit_rev":
"fd04501377fa6db3c12cdc1fbad0da376e97f35b"}

[commit-bot: I haz the power, 2016-12-02 21:29:12]

Description was changed from

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual
==========

to

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual
==========

[commit-bot: I haz the power, 2016-12-02 21:29:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 21:32:43]

Description was changed from

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual
==========

to

==========
Rewire the local sync switches through the pref store.

This CL is precursor to backing the switches by policies.

BUG=651411
TEST=unit tests, manual

Committed: https://crrev.com/0c13de516027b0ac22acc891b40fea8b7149240b
Cr-Commit-Position: refs/heads/master@{#436032}
==========

[commit-bot: I haz the power, 2016-12-02 21:32:44]

Patchset 2 (id:??) landed as
https://crrev.com/0c13de516027b0ac22acc891b40fea8b7149240b
Cr-Commit-Position: refs/heads/master@{#436032}