Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2528133002: Revert of Embedding-CSP: Refactoring directive strings into enum (Closed)

Created:
4 years ago by magjed_chromium
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Embedding-CSP: Refactoring directive strings into enum (patchset #6 id:140001 of https://codereview.chromium.org/2516383002/ ) Reason for revert: Causing WebKit Win x64 Builder to fail on webkit_unit_tests on Windows-7-SP1 ContentSecurityPolicyTest.DirectiveType: ContentSecurityPolicyTest.DirectiveType (run #1): [ RUN ] ContentSecurityPolicyTest.DirectiveType c:\c\win_layout\src hird_party\webkit\source\core rame\csp\contentsecuritypolicytest.cpp(950): error: Death test: ContentSecurityPolicy::getDirectiveName( ContentSecurityPolicy::DirectiveType::Undefined) Result: failed to die. Error msg: [ DEATH ] [3244:5672:1125/030930:3521831:WARNING:test_suite.cc(236)] Test launcher output path C:\Users\CHROME~2\AppData\Local\Temp!6_27934 est_results.xml exists. Not adding test launcher result printer. [ DEATH ] [ FAILED ] ContentSecurityPolicyTest.DirectiveType (67 ms) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/101390 Original issue's description: > Embedding-CSP: Refactoring directive strings into enum. > > This is an effort as part of the experimental feature. Causing > patch: https://codereview.chromium.org/2474903002 > > BUG=647588 > > Committed: https://crrev.com/a5e9944b7169dd3a3c9f2cb352aff3551b32cd12 > Cr-Commit-Position: refs/heads/master@{#434474} TBR=mkwst@chromium.org,jochen@chromium.org,amalika@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647588 Committed: https://crrev.com/d15fefad6620176d0d0e60588abd29a19acc9d02 Cr-Commit-Position: refs/heads/master@{#434483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -335 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 28 chunks +94 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 5 chunks +40 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 12 chunks +90 lines, -129 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
magjed_chromium
Created Revert of Embedding-CSP: Refactoring directive strings into enum
4 years ago (2016-11-25 12:03:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528133002/1
4 years ago (2016-11-25 12:03:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 12:04:55 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-25 12:08:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d15fefad6620176d0d0e60588abd29a19acc9d02
Cr-Commit-Position: refs/heads/master@{#434483}

Powered by Google App Engine
This is Rietveld 408576698