[PAUSED] Add a scope for disallowing style update when calling hasEditableStyle

Add a scope for disallowing style update when calling hasEditableStyle

Ideally, we would like to ensure clean style when calling hasEditableStyle.
However, there are some code paths calling it with dirty style, and furthermore,
in some situations where style cannot be updated (e.g., InStyleRecalc).

This patch introduces DocumentLifecycle::DisallowStyleRecalcScope. In future
patches, we will apply this scope in those trouble-making code paths, and
make sure that we don't update style in this scope.

BUG=667575

[Xiaocheng, 2016-11-25 08:28:30]

Description was changed from

==========
Add a scope for disallowing style update when in AX

BUG=668590
==========

to

==========
Add a scope for disallowing style update when calling hasEditableStyle

Ideally, we would like to ensure clean style when calling hasEditableStyle.
However, there are some code paths calling it with dirty style, and furthermore,
in some situations where style cannot be updated (e.g., InStyleRecalc).

This patch introduces DocumentLifecycle::DisallowStyleRecalcScope. In future
patches, we will apply this scope in those trouble-making code paths, so that
we won't update style when entering hasEditableStyle when we can't.

BUG=667575
==========

[Xiaocheng, 2016-11-25 08:28:34]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 08:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-11-25 08:29:13]

Description was changed from

==========
Add a scope for disallowing style update when calling hasEditableStyle

Ideally, we would like to ensure clean style when calling hasEditableStyle.
However, there are some code paths calling it with dirty style, and furthermore,
in some situations where style cannot be updated (e.g., InStyleRecalc).

This patch introduces DocumentLifecycle::DisallowStyleRecalcScope. In future
patches, we will apply this scope in those trouble-making code paths, so that
we won't update style when entering hasEditableStyle when we can't.

BUG=667575
==========

to

==========
Add a scope for disallowing style update when calling hasEditableStyle

Ideally, we would like to ensure clean style when calling hasEditableStyle.
However, there are some code paths calling it with dirty style, and furthermore,
in some situations where style cannot be updated (e.g., InStyleRecalc).

This patch introduces DocumentLifecycle::DisallowStyleRecalcScope. In future
patches, we will apply this scope in those trouble-making code paths, and
make sure that we don't update style in this scope.

BUG=667575
==========

[Xiaocheng, 2016-11-25 09:26:04]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-11-25 09:26:05]

PTAL.

[commit-bot: I haz the power, 2016-11-25 09:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 09:50:46]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-11-25 09:52:37]

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:84: :
m_state(Uninitialized),
How about moving these initialization into class declaration and make ctor just
|= default|?

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.h (right):

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.h:159:
WTF_MAKE_NONCOPYABLE(DisallowStyleRecalcScope);
Use |DISALLOW_COPY_AND_ASSIGN(DisallowStyleRecalcScope)|

[Xiaocheng, 2016-11-25 10:05:25]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2016-11-25 10:05:32]

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:84: :
m_state(Uninitialized),
On 2016/11/25 at 09:52:37, Yosi_UTC9 wrote:
> How about moving these initialization into class declaration and make ctor
just |= default|?

No objection, but that's a separate issue, though.

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentLifecycle.h (right):

https://codereview.chromium.org/2528113002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentLifecycle.h:159:
WTF_MAKE_NONCOPYABLE(DisallowStyleRecalcScope);
On 2016/11/25 at 09:52:37, Yosi_UTC9 wrote:
> Use |DISALLOW_COPY_AND_ASSIGN(DisallowStyleRecalcScope)|

Done.

[commit-bot: I haz the power, 2016-11-25 10:05:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 11:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:56:34]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-27 23:43:52]

lgtm