Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 2528103002: Views a11y: Add comment to explain usage of AXNodeData's |state| member. (Closed)

Created:
4 years ago by Patti Lor
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views a11y: Add comment to explain usage of AXNodeData's |state| member. AXNodeData::state is a bitmask used for setting accessible state flags such as ui::AX_STATE_DISABLED. It is initialised to 0xFFFFFF, which turns all flags on. This is done in order to more easily catch bugs where no flags are set at all - it must be cleared to 0x0 before use. Add a comment explaining this. BUG=668569 Committed: https://crrev.com/2f4e229335d9aa02d6a90307537fef92ba8be091 Cr-Commit-Position: refs/heads/master@{#435020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/accessibility/ax_node_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Patti Lor
Hi dmazzoni, PTAL - comment change only.
4 years ago (2016-11-25 03:44:34 UTC) #4
dmazzoni
lgtm
4 years ago (2016-11-29 16:34:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528103002/1
4 years ago (2016-11-29 16:34:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 17:24:57 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 17:28:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f4e229335d9aa02d6a90307537fef92ba8be091
Cr-Commit-Position: refs/heads/master@{#435020}

Powered by Google App Engine
This is Rietveld 408576698