chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java - Issue 2528073002: Add a flag in WebAPK's proto when the Web App Manifest is no longer available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Issue 2528073002: Add a flag in WebAPK's proto when the Web App Manifest is no longer available. (Closed)

Patch Set: Nits. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

index 8f83831faa1becdb6511e02ac2c34e91b2fd672a..55f6758a1beac9b1df09e727989578b81b948b57 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

@@ -76,7 +76,8 @@ public class WebApkUpdateManagerTest extends ChromeTabbedActivityTestBase {

}

@Override

- protected void updateAsync(WebApkInfo fetchedInfo, String bestIconUrl) {

+ protected void updateAsync(WebApkInfo fetchedInfo, String bestIconUrl,

+ boolean staleManifest) {

dominickn 2016/12/20 05:05:48 isManifestStale

Xi Han 2016/12/20 20:25:08 Done.

mNeedsUpdate = true;

}