Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2528073002: Add a flag in WebAPK's proto when the Web App Manifest is no longer available. (Closed)
Patch Set: Remove best_icon_hash. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index c24a66886f1d919d5d86d9a41f6c0baaeb25b304..6c45a043335b247b24ef1c21d8227ca56ddf7141 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_
#include <jni.h>
+#include <map>
#include <memory>
#include "base/android/scoped_java_ref.h"
@@ -65,17 +66,19 @@ class WebApkInstaller : public net::URLFetcherDelegate {
// after the request to install the WebAPK is sent to the Google Play server.
void UpdateAsync(content::BrowserContext* browser_context,
const FinishCallback& callback,
- const std::string& icon_murmur2_hash,
const std::string& webapk_package,
- int webapk_version);
+ int webapk_version,
+ bool stale_manifest,
+ const std::map<std::string, std::string>& icon_url_hash_map);
pkotwicz 2016/12/07 20:41:30 Nit: Name this |icon_url_to_murmur2_hash_map| to m
Xi Han 2016/12/09 18:40:11 Done.
// Same as UpdateAsync() but uses the passed in |request_context_getter|.
void UpdateAsyncWithURLRequestContextGetter(
net::URLRequestContextGetter* request_context_getter,
const FinishCallback& callback,
- const std::string& icon_murmur2_hash,
const std::string& webapk_package,
- int webapk_version);
+ int webapk_version,
+ bool stale_manifest,
+ const std::map<std::string, std::string>& icon_url_hash_map);
// Sets the timeout for the server requests.
void SetTimeoutMs(int timeout_ms);
@@ -210,10 +213,6 @@ class WebApkInstaller : public net::URLFetcherDelegate {
// WebAPK app icon.
const SkBitmap shortcut_icon_;
- // Murmur2 hash of the bitmap at the app icon URL prior to any transformations
- // being applied to the bitmap (such as encoding/decoding the icon bitmap).
- std::string shortcut_icon_murmur2_hash_;
-
// WebAPK server URL.
GURL server_url_;

Powered by Google App Engine
This is Rietveld 408576698