ios/web/web_state/DEPS - Issue 2528043002: Implement DownloadImage directly in WebStateImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/web_state/DEPS

Issue 2528043002: Implement DownloadImage directly in WebStateImpl (Closed)

Patch Set: Address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+skia/ext",
	rohitrao (ping after 24h) 2016/12/02 11:45:21 Could you restrict these rules a bit further, to t Could you restrict these rules a bit further, to the set that's in https://codereview.chromium.org/2541083002/diff/30001/ios/chrome/DEPS? Per the comment in that file, we only use parts of skia, so we should keep the deps rules as tight as we can. gambard 2016/12/02 12:07:08 Done. Show quoted text On 2016/12/02 11:45:21, rohitrao wrote: > Could you restrict these rules a bit further, to the set that's in > https://codereview.chromium.org/2541083002/diff/30001/ios/chrome/DEPS Per the > comment in that file, we only use parts of skia, so we should keep the deps > rules as tight as we can. Done.
	3 "+third_party/skia",

	4 ]

OLD	NEW

« no previous file with comments | « ios/web/public/web_state/ui/crw_web_delegate.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | no next file with comments »