Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: ios/web/web_state/web_state_impl.h

Issue 2528043002: Implement DownloadImage directly in WebStateImpl (Closed)
Patch Set: Add deps Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_ 5 #ifndef IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_
6 #define IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_ 6 #define IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 25 matching lines...) Expand all
36 } 36 }
37 37
38 namespace web { 38 namespace web {
39 39
40 class BrowserState; 40 class BrowserState;
41 struct ContextMenuParams; 41 struct ContextMenuParams;
42 struct Credential; 42 struct Credential;
43 struct FaviconURL; 43 struct FaviconURL;
44 struct LoadCommittedDetails; 44 struct LoadCommittedDetails;
45 class NavigationManager; 45 class NavigationManager;
46 class RawImageFetcher;
46 class WebInterstitialImpl; 47 class WebInterstitialImpl;
47 class WebStateDelegate; 48 class WebStateDelegate;
48 class WebStateFacadeDelegate; 49 class WebStateFacadeDelegate;
49 class WebStatePolicyDecider; 50 class WebStatePolicyDecider;
50 class WebUIIOS; 51 class WebUIIOS;
51 52
52 // Implementation of WebState. 53 // Implementation of WebState.
53 // Generally mirrors //content's WebContents implementation. 54 // Generally mirrors //content's WebContents implementation.
54 // General notes on expected WebStateImpl ownership patterns: 55 // General notes on expected WebStateImpl ownership patterns:
55 // - Outside of tests, WebStateImpls are created 56 // - Outside of tests, WebStateImpls are created
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 std::map<std::string, ScriptCommandCallback> script_command_callbacks_; 363 std::map<std::string, ScriptCommandCallback> script_command_callbacks_;
363 364
364 // Member variables should appear before the WeakPtrFactory<> to ensure that 365 // Member variables should appear before the WeakPtrFactory<> to ensure that
365 // any WeakPtrs to WebStateImpl are invalidated before its member variable's 366 // any WeakPtrs to WebStateImpl are invalidated before its member variable's
366 // destructors are executed, rendering them invalid. 367 // destructors are executed, rendering them invalid.
367 base::WeakPtrFactory<WebState> weak_factory_; 368 base::WeakPtrFactory<WebState> weak_factory_;
368 369
369 // Mojo interface registry for this WebState. 370 // Mojo interface registry for this WebState.
370 std::unique_ptr<service_manager::InterfaceRegistry> mojo_interface_registry_; 371 std::unique_ptr<service_manager::InterfaceRegistry> mojo_interface_registry_;
371 372
373 // Image Fetcher used to download favicons.
Eugene But (OOO till 7-30) 2016/11/30 17:13:50 This can download any image, not only favicons. Ri
gambard 2016/12/01 15:14:21 Yes but for now |downloadImage| is only called for
374 std::unique_ptr<RawImageFetcher> image_fetcher_;
375
372 DISALLOW_COPY_AND_ASSIGN(WebStateImpl); 376 DISALLOW_COPY_AND_ASSIGN(WebStateImpl);
373 }; 377 };
374 378
375 } // namespace web 379 } // namespace web
376 380
377 #endif // IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_ 381 #endif // IOS_WEB_WEB_STATE_WEB_STATE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698