ios/web/web_state/DEPS - Issue 2528043002: Implement DownloadImage directly in WebStateImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/web_state/DEPS

Issue 2528043002: Implement DownloadImage directly in WebStateImpl (Closed)

Patch Set: Add deps Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+skia/ext",

	3 "+third_party/skia",
	kkhorimoto 2016/11/28 23:56:50 I'm pretty sure that we don't want to introduce th I'm pretty sure that we don't want to introduce third_party deps from within web//. Eugene But (OOO till 7-30) 2016/11/30 17:13:49 +1 Can we use UIKit API for extracting image size? Show quoted text On 2016/11/28 23:56:50, kkhorimoto_ wrote: > I'm pretty sure that we don't want to introduce third_party deps from within > web//. +1 Can we use UIKit API for extracting image size? ios/web is a library and we should be cautious about it's binary size. gambard 2016/12/01 15:14:21 As explain in another CL: UIImage makes some assum Show quoted text On 2016/11/30 17:13:49, Eugene But wrote: > On 2016/11/28 23:56:50, kkhorimoto_ wrote: > > I'm pretty sure that we don't want to introduce third_party deps from within > > web//. > +1 Can we use UIKit API for extracting image size? ios/web is a library and we > should be cautious about it's binary size. As explain in another CL: UIImage makes some assumptions about the format/scale of the image. For example if you download a file favicon.ico containing multiple images, a UIImage representation will keep only one of them (from my understanding). gambard 2016/12/01 15:14:21 Actually, the ImageFetchedCallback type use a SkBi Show quoted text On 2016/11/30 17:13:49, Eugene But wrote: > On 2016/11/28 23:56:50, kkhorimoto_ wrote: > > I'm pretty sure that we don't want to introduce third_party deps from within > > web//. > +1 Can we use UIKit API for extracting image size? ios/web is a library and we > should be cautious about it's binary size. Actually, the ImageFetchedCallback type use a SkBitmap as a parameter type, so I don't see how I can be able to do it without a skia include.
	4 ]

OLD	NEW

« no previous file with comments | « ios/web/public/web_state/ui/crw_web_delegate.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | ios/web/web_state/web_state_impl.h » ('J')