Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 252803002: rAc: autofill invalid phone numbers (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 7 months ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: autofill invalid phone numbers rather than failing mysteriously, this will autofill the number and then mark it invalid. BUG=365630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
6 years, 8 months ago (2014-04-25 22:35:25 UTC) #1
please use gerrit instead
lgtm
6 years, 8 months ago (2014-04-25 22:39:01 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-25 22:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/252803002/1
6 years, 8 months ago (2014-04-25 22:42:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 03:31:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 03:31:16 UTC) #6
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 8 months ago (2014-04-28 05:29:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/252803002/1
6 years, 8 months ago (2014-04-28 05:30:27 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 07:39:31 UTC) #9
Message was sent while issue was closed.
Change committed as 266472

Powered by Google App Engine
This is Rietveld 408576698