[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation to ARC.Automatically generated ARC…

[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9
Cr-Commit-Position: refs/heads/master@{#436275}

[stkhapugin, 2016-11-24 15:55:54]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 15:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 16:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 16:42:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2016-11-25 09:53:00]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2016-11-25 09:53:00]

PTAL. Passed downstream tests.

[sdefresne, 2016-11-25 10:16:46]

lgtm

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm (right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm:35: } else {
nit: no else after return

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/location_manager.h (right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/location_manager.h:32: @property(weak, nonatomic,
readonly) CLLocation* currentLocation;
This is backed by a scoped_nsobject<>. I think it should be strong.

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm
(right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm:58:
base::WeakNSObject<OmniboxGeolocationAuthorizationAlert> weakSelf(self);
I thought you wanted to remove base::WeakNSObject<> and use __weak instead.

[stkhapugin, 2016-11-25 14:57:16]

PTAL

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm (right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm:35: } else {
On 2016/11/25 10:16:46, sdefresne wrote:
> nit: no else after return

Done.

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/location_manager.h (right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/location_manager.h:32: @property(weak, nonatomic,
readonly) CLLocation* currentLocation;
On 2016/11/25 10:16:46, sdefresne wrote:
> This is backed by a scoped_nsobject<>. I think it should be strong.

Done.

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
File ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm
(right):

https://codereview.chromium.org/2528003002/diff/1/ios/chrome/browser/geolocat...
ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm:58:
base::WeakNSObject<OmniboxGeolocationAuthorizationAlert> weakSelf(self);
On 2016/11/25 10:16:46, sdefresne wrote:
> I thought you wanted to remove base::WeakNSObject<> and use __weak instead.

Done.

[stkhapugin, 2016-12-05 11:59:43]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2016-12-05 11:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2528003002/#ps20001
(title: "comments, cleanup")

[commit-bot: I haz the power, 2016-12-05 11:59:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:26:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480939183413580,
"parent_rev": "f07e0957b43e2202b68c7abf22d664a90b59c826", "commit_rev":
"c0d88d1180157349e8577484eb19c098c44d02bd"}

[commit-bot: I haz the power, 2016-12-05 13:26:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 13:28:09]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9
Cr-Commit-Position: refs/heads/master@{#436275}
==========

[commit-bot: I haz the power, 2016-12-05 13:28:10]

Patchset 2 (id:??) landed as
https://crrev.com/4299c50ed4048a55d6f14d7220de5ef51cc411c9
Cr-Commit-Position: refs/heads/master@{#436275}