chrome/browser/chromeos/chrome_browser_main_chromeos.cc - Issue 2527973003: Consolidate code monitoring low memory kills and OOM kills to MemoryKillsMonitor on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 2527973003: Consolidate code monitoring low memory kills and OOM kills to MemoryKillsMonitor on ChromeOS. (Closed)

Patch Set: review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

index 8b9664c96a5188133531c695dc3ff250be5dc25f..59ed4e6aa21e6d4ce093e007c0cb0dd83ccbc730 100644

--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc

@@ -354,6 +354,10 @@ void ChromeBrowserMainPartsChromeos::PreEarlyInitialization() {

chrome::SetChannel(channel);

#endif

+ // Start monitoring OOM kills.

+ memory_kills_monitor_.reset(new memory::MemoryKillsMonitor::Handle(

sky 2016/11/29 20:55:02 Use MakeUnique if you can (see threads on chromium

cylee1 2016/11/30 17:18:57 Done.

+ memory::MemoryKillsMonitor::StartMonitoring()));

ChromeBrowserMainPartsLinux::PreEarlyInitialization();

}