Remove direct access to enqueuer through use of WorldImpact

Remove direct access to enqueuer through use of WorldImpact

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/c102d3f72a8cc44b2a7a24aaba6bdc030f338b7b

[Johnni Winther, 2016-11-25 14:39:07]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-11-28 19:03:06]

lgtm

nice!

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:151: /// Called to register that an
instantiated generic class has a call method.
is this method called even if the call method does not reference the generic
type variables?

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:94: // to `false` here.
you mean set [queueIsClosed] to true?

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:1373: // Calls to
[:computeSignature:] are generated by the emitter and we
this comment is very out of date

[Johnni Winther, 2016-11-29 08:01:37]

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:151: /// Called to register that an
instantiated generic class has a call method.
On 2016/11/28 19:03:06, Harry Terkelsen wrote:
> is this method called even if the call method does not reference the generic
> type variables?

Yes. Added a note to the comment.

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:94: // to `false` here.
On 2016/11/28 19:03:06, Harry Terkelsen wrote:
> you mean set [queueIsClosed] to true?

Yes :)

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2527973002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:1373: // Calls to
[:computeSignature:] are generated by the emitter and we
On 2016/11/28 19:03:06, Harry Terkelsen wrote:
> this comment is very out of date

Removed.

[Johnni Winther, 2016-11-29 08:06:03]

Description was changed from

==========
Remove direct access to enqueuer through use of WorldImpact
==========

to

==========
Remove direct access to enqueuer through use of WorldImpact

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c102d3f72a8cc44b2a7a24aaba6bdc030f338b7b
==========

[Johnni Winther, 2016-11-29 08:06:05]

Committed patchset #3 (id:40001) manually as
c102d3f72a8cc44b2a7a24aaba6bdc030f338b7b (presubmit successful).