Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 252793003: Undo the recent stress changes to the context loss test. (Closed)

Created:
6 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Undo the recent stress changes to the context loss test. The underlying infrastructure isn't ready for this to crash the GPU process 30 times in a row. Change back to running this test once to address continued flakiness on the bots. BUG=365904 NOTRY=true TBR=bajones@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing, even though the try servers are down right now.
6 years, 8 months ago (2014-04-26 01:07:47 UTC) #1
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 8 months ago (2014-04-26 01:07:59 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was unchecked by kbr@chromium.org
6 years, 8 months ago (2014-04-26 02:01:26 UTC) #3
Ken Russell (switch to Gerrit)
I'm committing this by hand. Tested locally, and this will only green up the tree.
6 years, 8 months ago (2014-04-26 02:03:05 UTC) #4
Ken Russell (switch to Gerrit)
Committed patchset #1 manually as r266315 (presubmit successful).
6 years, 8 months ago (2014-04-26 02:03:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/252793003/1
6 years, 8 months ago (2014-04-26 02:05:46 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 02:05:50 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for content/test/gpu/gpu_tests/context_lost.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/test/gpu/gpu_tests/context_lost.py
  Hunk #1 FAILED at 113.
  1 out of 1 hunk FAILED -- saving rejects to file
content/test/gpu/gpu_tests/context_lost.py.rej

Patch:       content/test/gpu/gpu_tests/context_lost.py
Index: content/test/gpu/gpu_tests/context_lost.py
diff --git a/content/test/gpu/gpu_tests/context_lost.py
b/content/test/gpu/gpu_tests/context_lost.py
index
64e4f5b4dc0890de6f19eed920095b67c41bea58..f80a78e632f1994eb9ee44c7682e77d62f07e30c
100644
--- a/content/test/gpu/gpu_tests/context_lost.py
+++ b/content/test/gpu/gpu_tests/context_lost.py
@@ -113,7 +113,7 @@ class ContextLost(test_module.Test):
               'javascript': 'window.domAutomationController._loaded' }
           ],
           'kill_gpu_process': True,
-          'number_of_gpu_process_kills': 30,
+          'number_of_gpu_process_kills': 1,
         },
         {
           'name': 'ContextLost.WebGLContextLostFromLoseContextExtension',

Powered by Google App Engine
This is Rietveld 408576698