Fix one more RenderFrame/RenderView ID mixup in printing code.

chrome/browser/ui/webui/print_preview/print_preview_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview/print_preview_handler.h"
 
 #include <ctype.h>
 #include <stddef.h>
 
 #include <map>
@@ skipping 894 matching lines @@
       ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG);
     } else {
       UMA_HISTOGRAM_COUNTS("PrintPreview.PageCount.PrintToPrinter", page_count);
       ReportUserActionHistogram(PRINT_TO_PRINTER);
     }
 
     // This tries to activate the initiator as well, so do not clear the
     // association with the initiator yet.
     print_preview_ui()->OnHidePreviewDialog();
 
+    // Grab the current initiator before calling ClearInitiatorDetails() below.
+    // Otherwise calling GetInitiator() later will return the wrong WebContents.
+    // https://crbug.com/407080
+    WebContents* initiator = GetInitiator();
+    if (initiator) {
+      // Save initiator IDs. PrintMsg_PrintForPrintPreview below should cause
+      // the renderer to send PrintHostMsg_UpdatePrintSettings and trigger
+      // PrintingMessageFilter::OnUpdatePrintSettings(), which needs this info.
+      auto* main_render_frame = initiator->GetMainFrame();
+      settings->SetInteger(printing::kPreviewInitiatorHostId,
+                           main_render_frame->GetProcess()->GetID());
+      settings->SetInteger(printing::kPreviewInitiatorRoutingId,
+                           main_render_frame->GetRoutingID());
+    }
+
     // Do this so the initiator can open a new print preview dialog, while the
     // current print preview dialog is still handling its print job.
-    WebContents* initiator = GetInitiator();
-    if (initiator) {
-      // Save initiator IDs. |PrintingMessageFilter::OnUpdatePrintSettings|
-      // would be called when initiator info is cleared.
-      settings->SetInteger(printing::kPreviewInitiatorHostId,
-                           initiator->GetRenderProcessHost()->GetID());
-      settings->SetInteger(printing::kPreviewInitiatorRoutingId,
-                           initiator->GetRoutingID());
-    }
-
     ClearInitiatorDetails();
 
     // The PDF being printed contains only the pages that the user selected,
     // so ignore the page range and print all pages.
-    settings->Remove(printing::kSettingPageRange, NULL);
+    settings->Remove(printing::kSettingPageRange, nullptr);
     // Reset selection only flag for the same reason.
     settings->SetBoolean(printing::kSettingShouldPrintSelectionOnly, false);
 
     // Set ID to know whether printing is for preview.
     settings->SetInteger(printing::kPreviewUIID,
                          print_preview_ui()->GetIDForPrintPreviewUI());
     RenderFrameHost* rfh = preview_web_contents()->GetMainFrame();
     rfh->Send(
         new PrintMsg_PrintForPrintPreview(rfh->GetRoutingID(), *settings));
 
@@ skipping 755 matching lines @@
 
 void PrintPreviewHandler::UnregisterForGaiaCookieChanges() {
   if (gaia_cookie_manager_service_)
     gaia_cookie_manager_service_->RemoveObserver(this);
 }
 
 void PrintPreviewHandler::SetPdfSavedClosureForTesting(
     const base::Closure& closure) {
   pdf_file_saved_closure_ = closure;
 }