Revert of [base] Pass scalar arguments by value in CHECK/DCHECK

Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3 id:40001 of https://codereview.chromium.org/2524093002/ )

Reason for revert:
Seems to cause compile errors on Android. Will investigate on Monday.

Original issue's description:
> [base] Pass scalar arguments by value in CHECK/DCHECK
>
> This not only potentially improves performance, but also avoids weird
> linker errors, like the one below, where I used Smi::kMinValue in a
> DCHECK_EQ.
>
> > [421/649] LINK ./mksnapshot
> > FAILED: mksnapshot
> > src/base/logging.h|178| error: undefined reference to
>   'v8::internal::Smi::kMinValue'
>
> R=bmeurer@chromium.org, ishell@chromium.org
>
> Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3
> Cr-Commit-Position: refs/heads/master@{#41273}

TBR=bmeurer@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/29ee62443d87f8cdcf0157715f5205ab45d99c94
Cr-Commit-Position: refs/heads/master@{#41278}

[Clemens Hammacher, 2016-11-24 20:10:43]

Created Revert of [base] Pass scalar arguments by value in CHECK/DCHECK

[Michael Hablich, 2016-11-24 23:01:27]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:01:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 23:01:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:01:38]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Michael Hablich, 2016-11-24 23:02:30]

On 2016/11/24 23:01:38, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

lgtm

[Michael Hablich, 2016-11-24 23:02:35]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:02:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 23:02:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480028555512180, "parent_rev":
"888d1809f8eba1b8d6a2c54cc60e903ca65fe893", "commit_rev":
"21603f920ddddb2e01da6787364b72bafbef39d3"}

[commit-bot: I haz the power, 2016-11-24 23:02:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 23:03:19]

Description was changed from

==========
Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3
id:40001 of https://codereview.chromium.org/2524093002/ )

Reason for revert:
Seems to cause compile errors on Android. Will investigate on Monday. 

Original issue's description:
> [base] Pass scalar arguments by value in CHECK/DCHECK
> 
> This not only potentially improves performance, but also avoids weird
> linker errors, like the one below, where I used Smi::kMinValue in a
> DCHECK_EQ.
> 
> > [421/649] LINK ./mksnapshot
> > FAILED: mksnapshot
> > src/base/logging.h|178| error: undefined reference to
>   'v8::internal::Smi::kMinValue'
> 
> R=bmeurer@chromium.org, ishell@chromium.org
> 
> Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3
> Cr-Commit-Position: refs/heads/master@{#41273}

TBR=bmeurer@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3
id:40001 of https://codereview.chromium.org/2524093002/ )

Reason for revert:
Seems to cause compile errors on Android. Will investigate on Monday.

Original issue's description:
> [base] Pass scalar arguments by value in CHECK/DCHECK
>
> This not only potentially improves performance, but also avoids weird
> linker errors, like the one below, where I used Smi::kMinValue in a
> DCHECK_EQ.
>
> > [421/649] LINK ./mksnapshot
> > FAILED: mksnapshot
> > src/base/logging.h|178| error: undefined reference to
>   'v8::internal::Smi::kMinValue'
>
> R=bmeurer@chromium.org, ishell@chromium.org
>
> Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3
> Cr-Commit-Position: refs/heads/master@{#41273}

TBR=bmeurer@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/29ee62443d87f8cdcf0157715f5205ab45d99c94
Cr-Commit-Position: refs/heads/master@{#41278}
==========

[commit-bot: I haz the power, 2016-11-24 23:03:20]

Patchset 1 (id:??) landed as
https://crrev.com/29ee62443d87f8cdcf0157715f5205ab45d99c94
Cr-Commit-Position: refs/heads/master@{#41278}