Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2527883002: ServiceWorker: mojofy ipcs sent from SWNetworkProvider (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
Reviewers:
dcheng, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, abarth-chromium, Aaron Boodman, kinuko+serviceworker, yzshen+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: mojofy ipcs sent from SWNetworkProvider BUG=629701 Committed: https://crrev.com/38045133f238c00cc1d2010dda90b7bb47a219cb Cr-Commit-Position: refs/heads/master@{#434593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M content/common/service_worker/service_worker.mojom View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
shimazu
ptal
4 years ago (2016-11-24 07:52:35 UTC) #4
horo
lgtm
4 years ago (2016-11-24 09:00:29 UTC) #5
shimazu
dcheng@: could you take a look at mojom?
4 years ago (2016-11-24 09:32:40 UTC) #7
dcheng
mojo lgtm
4 years ago (2016-11-25 00:11:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527883002/1
4 years ago (2016-11-28 01:03:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 02:22:40 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-28 02:24:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38045133f238c00cc1d2010dda90b7bb47a219cb
Cr-Commit-Position: refs/heads/master@{#434593}

Powered by Google App Engine
This is Rietveld 408576698