ui/gfx/codec/install_skia_codec.h - Issue 2527833002: Implement SkEncodeImage()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/codec/install_skia_codec.h

Issue 2527833002: Implement SkEncodeImage() (Closed)

Patch Set: remove size check Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	dcheng 2016/12/20 19:40:47 Nit: rename this file to something like skia_image Nit: rename this file to something like skia_image_encoder_adapter. hal.canary 2016/12/20 20:45:08 Done. Show quoted text On 2016/12/20 19:40:47, dcheng wrote: > Nit: rename this file to something like skia_image_encoder_adapter. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_CODEC_INSTALL_SKIA_CODEC_H

	6 #define UI_GFX_CODEC_INSTALL_SKIA_CODEC_H

	7

	8 #include "third_party/skia/include/core/SkEncodedImageFormat.h"

	9 #include "ui/gfx/gfx_export.h"

	10

	11 class SkWStream;

	12 class SkPixmap;

	13

	14 namespace gfx {

	15

	16 // Matches signature of Skia's SkEncodeImage, but makes use of Chromium's

	17 // encoders.

	18 GFX_EXPORT bool EncodeImage(SkWStream* dst,
	dcheng 2016/12/20 19:40:47 Nit: call this something less generic, since it's Nit: call this something less generic, since it's an adapter to help Skia use the gfx image encoding functions, instead of a generic EncodeImage function. hal.canary 2016/12/20 20:45:09 Done. Show quoted text On 2016/12/20 19:40:47, dcheng wrote: > Nit: call this something less generic, since it's an adapter to help Skia use > the gfx image encoding functions, instead of a generic EncodeImage function. Done.
	19 const SkPixmap& pixmap,

	20 SkEncodedImageFormat format,

	21 int quality);

	22

	23 } // namespace gfx

	24

	25 #endif // UI_GFX_CODEC_INSTALL_SKIA_CODEC_H

OLD	NEW

« skia/ext/skia_encode_image.h ('K') | « ui/gfx/BUILD.gn ('k') | ui/gfx/codec/install_skia_codec.cc » ('j') | no next file with comments »