skia/ext/skia_encode_image.h - Issue 2527833002: Implement SkEncodeImage()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: skia/ext/skia_encode_image.h

Issue 2527833002: Implement SkEncodeImage() (Closed)

Patch Set: remove size check Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SKIA_EXT_SKIA_ENCODE_IMAGE_H

	6 #define SKIA_EXT_SKIA_ENCODE_IMAGE_H

	7

	8 #include "third_party/skia/include/core/SkEncodedImageFormat.h"

	9 #include "third_party/skia/include/core/SkTypes.h"

	10

	11 class SkPixmap;

	12 class SkWStream;

	13

	14 namespace skia {

	15

	16 typedef bool (ImageEncoder)(SkWStream,

	17 const SkPixmap&,

	18 SkEncodedImageFormat,

	19 int quality);
	dcheng 2016/12/20 19:40:47 Prefer using A = B over typedef B A in new code. Prefer using A = B over typedef B A in new code. Also, I'd suffix this with "Function" and not include the pointer explicitly, so it's clear from the function signature that we're passing a function pointer, i.e. something like: SK_API void SetImageEncoder(ImageEncoderFunction); hal.canary* 2016/12/20 20:45:08 Done. Show quoted text On 2016/12/20 19:40:47, dcheng wrote: > Prefer using A = B over typedef B A in new code. > > Also, I'd suffix this with "Function" and not include the pointer explicitly, so > it's clear from the function signature that we're passing a function pointer, > i.e. something like: > SK_API void SetImageEncoder(ImageEncoderFunction*); Done.
	20

	21 SK_API void SetImageEncoder(ImageEncoder);

	22

	23 } // namespace skia

	24

	25 #endif // SKIA_EXT_SKIA_ENCODE_IMAGE_H

OLD	NEW